-
-
Notifications
You must be signed in to change notification settings - Fork 4
Type Hint Added to Modules #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #72 +/- ##
==========================================
+ Coverage 93.84% 93.89% +0.06%
==========================================
Files 4 4
Lines 227 229 +2
Branches 30 30
==========================================
+ Hits 213 215 +2
Misses 11 11
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CHANGELOG.md
Outdated
|
|
||
| ## [Unreleased] | ||
| ### Changed | ||
| + Python typing features added to all modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Python typing features added to all modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 7964252.
nava/functions.py
Outdated
| :return: inner function | ||
| """ | ||
| def quote(func: Callable) -> Callable: | ||
| """Quote the given shell string.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add :param func: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in e0c85cb.
nava/functions.py
Outdated
| :return: inner function | ||
| """ | ||
| def path_check(func: Callable) -> Callable: | ||
| """Check the given path to be a string and a valid file directory.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add :param func: ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in e0c85cb.
sepandhaghighi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Reference Issues/PRs
What does this implement/fix? Explain your changes.
This PR adds type hint to Nava modules.
Any other comments?
Local tests on OSs