Skip to content

Conversation

@sadrasabouri
Copy link
Member

@sadrasabouri sadrasabouri commented Dec 27, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR adds type hint to Nava modules.

Any other comments?

Local tests on OSs

  • macOS
    • Sonoma
  • Windows
    • Windows 11
  • Linux
    • Ubuntu 22.04

@sadrasabouri sadrasabouri added this to the nava v0.9 milestone Dec 27, 2025
@sadrasabouri sadrasabouri self-assigned this Dec 27, 2025
@sadrasabouri sadrasabouri added the enhancement New feature or request label Dec 27, 2025
@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (1e55d5a) to head (e0c85cb).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #72      +/-   ##
==========================================
+ Coverage   93.84%   93.89%   +0.06%     
==========================================
  Files           4        4              
  Lines         227      229       +2     
  Branches       30       30              
==========================================
+ Hits          213      215       +2     
  Misses         11       11              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sadrasabouri sadrasabouri marked this pull request as ready for review December 27, 2025 01:55
CHANGELOG.md Outdated

## [Unreleased]
### Changed
+ Python typing features added to all modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- Python typing features added to all modules

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 7964252.

@sepandhaghighi sepandhaghighi added the documentation Improvements or additions to documentation label Dec 27, 2025
:return: inner function
"""
def quote(func: Callable) -> Callable:
"""Quote the given shell string."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add :param func: ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e0c85cb.

:return: inner function
"""
def path_check(func: Callable) -> Callable:
"""Check the given path to be a string and a valid file directory."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add :param func: ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in e0c85cb.

Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit c0997d1 into dev Dec 30, 2025
35 checks passed
@sepandhaghighi sepandhaghighi deleted the type-hint branch December 30, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants