Pin and update docker shas #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By explicitly adding shas for all 3 versions of ubuntu, we should be able to get dependabot to create PRs to update them to new versions as part of our regular update process.
Member
Author
|
Hmm, seems it didn't like it, dependabot errored https://github.com/opensafely-core/base-docker/actions/runs/21404899658/job/61625912545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took advantage of moment of inspiration to try tackle this issue again.
Dependabot can update shas in dockerfiles, which is nice, as we can then manage
them in our regular update process.
Additionally, they help solve another problem. Currently, our weekly rebuilds
do not make commits to repo, so they deactivate after 3 months. However, merging
a dependabot PR will update the repo, and the weekly publish will no longer be
deactivated.
The issue has been that we use single parametrised Dockerfile, in order to keep
the images identical. This had previously precluded pinning the sha. However,
explicit pinned layers per version, and some tweaks to parameterisation,
I think we can do it.
We won't 100% know if this will work as intended until we merge it, but its
worth a shot.