Skip to content

bugfix: fix the compatibility issue for freenginx.#2476

Merged
zhuizhuhaomeng merged 1 commit intoopenresty:masterfrom
u5surf:fix_freenginx_build
Feb 8, 2026
Merged

bugfix: fix the compatibility issue for freenginx.#2476
zhuizhuhaomeng merged 1 commit intoopenresty:masterfrom
u5surf:fix_freenginx_build

Conversation

@u5surf
Copy link
Contributor

@u5surf u5surf commented Feb 8, 2026

I hereby granted the copyright of the changes in this pull request
to the authors of this lua-nginx-module project.

We encountered the following build failure because the freenginx has been defined ngx_ssl_client_hello_callback.
We should fix to build issue for freenginx.

$ make
make -f objs/Makefile
make[1]: Entering directory '/home/ubuntu/freenginx'
cc -c -I/usr/local/include/luajit-2.1  -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g  -DNDK_SET_VAR  -I src/core -I src/event -I src/event/modules -I src/event/quic -I src/os/unix -I /home/ubuntu/ngx_devel_kit/objs -I objs/addon/ndk -I /home/ubuntu/lua-nginx-module/src/api -I objs -I src/http -I src/http/modules -I /home/ubuntu/ngx_devel_kit/src -I /home/ubuntu/ngx_devel_kit/src -I /home/ubuntu/ngx_devel_kit/objs -I objs/addon/ndk -I /usr/local/include/luajit-2.1 \
        -o objs/addon/src/ngx_http_lua_ssl_client_helloby.o \
        /home/ubuntu/lua-nginx-module/src/ngx_http_lua_ssl_client_helloby.c
/home/ubuntu/lua-nginx-module/src/ngx_http_lua_ssl_client_helloby.c: In function ‘ngx_http_lua_ssl_client_hello_handler’:
/home/ubuntu/lua-nginx-module/src/ngx_http_lua_ssl_client_helloby.c:226:10: error: implicit declaration of function ‘ngx_ssl_client_hello_callback’ [-Werror=implicit-function-declaration]
  226 |     rc = ngx_ssl_client_hello_callback(ssl_conn, al, arg);
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1792: objs/addon/src/ngx_http_lua_ssl_client_helloby.o] Error 1
make[1]: Leaving directory '/home/ubuntu/freenginx'
make: *** [Makefile:10: build] Error 2

@zhuizhuhaomeng zhuizhuhaomeng merged commit 0b14a04 into openresty:master Feb 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants