add singler python implementation #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LouisK92
requested changes
Dec 12, 2025
Contributor
LouisK92
left a comment
LouisK92
left a comment
There was a problem hiding this comment.
Added a few comments in the code. But component looks almost perfect now.
To include the method also into the pipeline there are a few files that need small adjustments:
1. workflow configuration
task_ist_preprocessing/src/workflows/run_benchmark/config.vsh.yaml
- line 101: add singler to
default: "ssam:tacco:moscot:mapmycells:tangram" - line 172: add singler to dependencies
2. workflow file
task_ist_preprocessing/src/workflows/run_benchmark/main.nf
- line 379: add singler to ct annotation methods
3. script to run the benchmark
task_ist_preprocessing/scripts/run_benchmark/*.sh
In each script add singler to the celltype_annotation_methods (comment it out if most other methods are commented out)
LouisK92
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!