This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Fixed Double to Long cast bug for nw_dst when reading config #269
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On startup, when parsing the JSON config file where the field nw_dst is present for a flowspace rule, an exception occurs that Double can't be cast to Long.
This is due to GSON parsing every number as Double and FlowSpaceImpl expecting a Long (which it could be if GSON wouldn't parse it as Double...) after taking the argument out of the HashMap. The casts of all the other values are already Double casts, so I guess someone simply forgot to change it.