Skip to content

Comments

SYNCT-58: Added PersonObject class for Person Object Pull and Push#153

Open
jnsereko wants to merge 1 commit intoopenmrs:masterfrom
jnsereko:SYNCT-58
Open

SYNCT-58: Added PersonObject class for Person Object Pull and Push#153
jnsereko wants to merge 1 commit intoopenmrs:masterfrom
jnsereko:SYNCT-58

Conversation

@jnsereko
Copy link

@jnsereko jnsereko commented Apr 22, 2020

https://issues.openmrs.org/browse/SYNCT-58
SYNCT-58: Added PersonObject class. I am trying to implement Pulling and Pushing for Person Object but i have little knowledge of what is to be done.
I am kinder pulsed on how to finish this ticket. But i request your view on what else to add on, or more information resources.
Should i also include the method equals() and hashcode() in this class or it is not important?
cc @dkayiwa @tendomart @mozzy11 @reagan-meant

Copy link

@tendomart tendomart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnsereko a couple of things to note , your Title is not clear , you have plenty of useless spaces. You may remove them .

@tendomart
Copy link

You are required to add logic for essentially doing REST /FHIR transactions .

Did you look at https://wiki.openmrs.org/display/docs/Adding+a+Web+Service+Step+by+Step+Guide+for+Core+Developers
and
https://wiki.openmrs.org/display/projects/OpenMRS+FHIR+Module

@jnsereko jnsereko changed the title SYNCT-58: Added PersonObject class. I wasn to create an implementati… SYNCT-58: Added PersonObject class for Person Object Pull and Push Apr 22, 2020
@jnsereko
Copy link
Author

jnsereko commented Apr 22, 2020

You are required to add logic for essentially doing REST /FHIR transactions .

Did you look at https://wiki.openmrs.org/display/docs/Adding+a+Web+Service+Step+by+Step+Guide+for+Core+Developers
and
https://wiki.openmrs.org/display/projects/OpenMRS+FHIR+Module

Thank you @tendomart. I had only looked at https://wiki.openmrs.org/display/projects/OpenMRS+FHIR+Module
but let me checkout the first link you sent me.

So this means i dont hhave to worry with the api files in Sync 2

@reagan-meant
Copy link
Contributor

You may want to checkout this @jnsereko https://talk.openmrs.org/t/development-in-sync/28001?u=reagan

@tendomart
Copy link

How then would you exchange the info ?Im just thinking out loud anyway ? And which API files do you mean ?

@jnsereko
Copy link
Author

And which API files do you mean ?

i mean the classes in openmrs-module-sync API classes

How then would you exchange the info ?Im just thinking out loud anyway ?

OK point noted.

@mozzy11
Copy link
Member

mozzy11 commented Apr 22, 2020

@jnsereko well done ,But you need to fully undesrtand How Sync2 works. you dont have to re-define again the model classes .
you can take a look at some sample work i did here for Person Attribute

That being said , this ticket seems irrelevant , because already Person Objects are Being synced succesfully. see comments on the ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants