SYNCT-336 : Sync2 should dispaly a right message on failure or success#147
Open
mozzy11 wants to merge 1 commit intoopenmrs:masterfrom
Open
SYNCT-336 : Sync2 should dispaly a right message on failure or success#147mozzy11 wants to merge 1 commit intoopenmrs:masterfrom
mozzy11 wants to merge 1 commit intoopenmrs:masterfrom
Conversation
ODORA0
reviewed
Aug 12, 2019
| ParentFeedReader parentFeedReader = ContextUtils.getParentFeedReader(); | ||
| parentFeedReader.pullAndProcessAllFeeds(); | ||
| Integer lastAuditMsgId = syncAuditService.getCountOfMessages().intValue(); | ||
| Boolean succes = syncAuditService.getMessageById(lastAuditMsgId).getSuccess(); |
Member
There was a problem hiding this comment.
I don't know, but did you intend to use Boolean success rather than Boolean succes
Member
|
@mozzy11 Any interest in seeing this through? |
|
@mozzy11 are you interested in seeing this through or should we close it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://issues.openmrs.org/browse/SYNCT-336
Sync2 should dispaly a right message on failure or success