RA-488:Correct the <p> id of when and where in the Visit Note HTML Form

[Wandji69]

https://issues.openmrs.org/browse/RA-488
Update the ID of the <p> tag in the simpleVisitNote.xml

[AppBankDigital]

@Wandji69 It looks the issue was fixed. Thank you so much for fixing this.

[Wandji69]

@Wandji69 It looks the issue was fixed. Thank you so much for fixing this.
Thanks for checking

[Wandji69]

Yes I did. Best Regards Collins Chuwa, Wandji.

…

On 16 Sep 2020, at 12:26 PM, MAGEMBE SHARIF ***@***.***> wrote: @sherrif10 commented on this pull request. In omod/src/main/webapp/resources/htmlforms/simpleVisitNote.xml: > @@ -43,16 +43,16 @@ <ifMode mode="VIEW" include="false"> <h2><uimessage code="referenceapplication.visitNote.title"/></h2> - <div id="who-when-where"> + <div id="who-where-when"> Thanks @Wandji69 did you test this out locally — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[sherrif10]

Can you please add ticket id

[sherrif10]

can you edit your first comment and include it there, i think thats the better

[Wandji69]

Thanks, @sherrif10

[Wandji69]

This PR has been stale for some time now cc @sherrif10

[sherrif10]

Thanks For working on this @Wandji69 , LGTM however do you mind sharing the screenshot of your test case to confirm this .

[Wandji69]

@sherrif10 here is a screenshot of the test, sorry for the late reply,

[HerbertYiga]

@dkayiwa does this look good for merging so that we close off the ticket

[sherrif10]

@Wandji69 this is not the screen shot i meant, i meant after testing it locally on the running instance

[sherrif10]

ideally we would love seeing a screen shot like

after carryiing a test , this would convince reviewers like @dkayiwa to get it merged

[sherrif10]

You can try to inspect

to ease ur work

[Wandji69]

Ok! I will do this and send. -- B.R Collins C. Wandji No: +237672965154 https://Wandji69.me

[Wandji69]

here is a screenshot of testing the changes.

[sherrif10]

Thanks , is it possible to make the Date tab equal to the add Presumed tab to be with the same length atleast, otherwise LGTM cc @dkayiwa