Skip to content

Conversation

@gnu-andrew
Copy link
Member

@gnu-andrew gnu-andrew commented Dec 27, 2025

Update to the latest version of libpng. Change includes both the backport of the latest libpng change, JDK-8372534, and previous updates not present in 8u (JDK-8316030 - 1.6.40, JDK-8329004 - 1.6.43, JDK-8348598 - 1.6.47). The change built fine with GCC 8 on RHEL 8 and java/awt/SplashScreen tests passed.

I also included UPDATING.txt introduced in JDK-8208353 in 11u, but not 8u, and updated in JDK-8295685 as part of the JDK-8329004 backport which updates it.

I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8329004 needs maintainer approval
  • JDK-8348598 needs maintainer approval
  • JDK-8316030 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8372534 needs maintainer approval
  • Commit message must refer to an issue

Issues

  • JDK-8372534: Update Libpng to 1.6.51 (Bug - P3 - Approved)
  • JDK-8316030: Update Libpng to 1.6.40 (Bug - P3 - Approved)
  • JDK-8329004: Update Libpng to 1.6.43 (Bug - P3 - Approved)
  • JDK-8348598: Update Libpng to 1.6.47 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.org/jdk8u.git pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/83.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2025

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 27, 2025

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8372534: Update Libpng to 1.6.51
8316030: Update Libpng to 1.6.40
8329004: Update Libpng to 1.6.43
8348598: Update Libpng to 1.6.47

Reviewed-by: abakhtin, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8191f621993f5c271e31d18aa385333e39d6a919 8316030: Update Libpng to 1.6.40 Dec 27, 2025
@openjdk
Copy link

openjdk bot commented Dec 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 27, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2025

Webrevs

@gnu-andrew gnu-andrew changed the title 8316030: Update Libpng to 1.6.40 Backport be7966c633830516c703f14610e4fef1bbe7f57d Dec 27, 2025
@openjdk openjdk bot changed the title Backport be7966c633830516c703f14610e4fef1bbe7f57d 8372534: Update Libpng to 1.6.51 Dec 27, 2025
@openjdk
Copy link

openjdk bot commented Dec 27, 2025

This backport pull request has now been updated with issue from the original commit.

@gnu-andrew
Copy link
Member Author

/issue add 8316030 8329004 8348598

@openjdk
Copy link

openjdk bot commented Dec 27, 2025

@gnu-andrew
Adding additional issue to issue list: 8316030: Update Libpng to 1.6.40.

Adding additional issue to issue list: 8329004: Update Libpng to 1.6.43.

Adding additional issue to issue list: 8348598: Update Libpng to 1.6.47.

@alexeybakhtin
Copy link
Contributor

Thank you for the backport.
I'm not a reviewer, but it looks good to me. I do not see any regressions.

@gnu-andrew
Copy link
Member Author

Thank you for the backport. I'm not a reviewer, but it looks good to me. I do not see any regressions.

Thanks Alexey. I'll have to move this over to 8u-dev now as we are post-freeze, but still plan to include this in the January release in sync with the later JDK releases.

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@gnu-andrew
Copy link
Member Author

/approval request Regular updates for the in-tree copy of libpng, handling the 1.6.40, 1.6.43, 1.6.47 & 1.6.51 updates under one pull request. The code backports were clean. The documentation had to be ported to THIRD_PARTY_README manually. GHA builds & testing have passed (bar one now excluded test) and the change has been reviewed by Alexey Bakhtin & Sergey Bylokhov

@openjdk
Copy link

openjdk bot commented Jan 7, 2026

@gnu-andrew
8372534: The approval request has been created successfully.
8316030: The approval request has been created successfully.
8329004: The approval request has been created successfully.
8348598: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 7, 2026
@jerboaa
Copy link
Contributor

jerboaa commented Jan 7, 2026

Quoting Sergey from openjdk/jdk8u-dev#729:

Please confirm that the splashscreen tests works fine on macOS, Linux, and Windows. test/java/awt/SplashScreen/*

@gnu-andrew
Copy link
Member Author

Quoting Sergey from openjdk/jdk8u-dev#729:

Please confirm that the splashscreen tests works fine on macOS, Linux, and Windows. test/java/awt/SplashScreen/*

As already stated in the PR header, "The change built fine with GCC 8 on RHEL 8 and java/awt/SplashScreen tests passed".

@jerboaa
Copy link
Contributor

jerboaa commented Jan 8, 2026

OK, thanks.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 8, 2026

/approve yes

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@jerboaa
8372534: The approval request has been approved.
8316030: The approval request has been approved.
8329004: The approval request has been approved.
8348598: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 8, 2026
@gnu-andrew
Copy link
Member Author

Thanks.
/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2026

Going to push as commit 976d0a1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2026
@openjdk openjdk bot closed this Jan 8, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2026
@openjdk
Copy link

openjdk bot commented Jan 8, 2026

@gnu-andrew Pushed as commit 976d0a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants