-
Notifications
You must be signed in to change notification settings - Fork 227
8372534: Update Libpng to 1.6.51 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
|
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
This backport pull request has now been updated with issue from the original commit. |
|
/issue add 8316030 8329004 8348598 |
|
@gnu-andrew Adding additional issue to issue list: Adding additional issue to issue list: |
|
Thank you for the backport. |
Thanks Alexey. I'll have to move this over to 8u-dev now as we are post-freeze, but still plan to include this in the January release in sync with the later JDK releases. |
|
|
|
/approval request Regular updates for the in-tree copy of libpng, handling the 1.6.40, 1.6.43, 1.6.47 & 1.6.51 updates under one pull request. The code backports were clean. The documentation had to be ported to |
|
@gnu-andrew |
|
Quoting Sergey from openjdk/jdk8u-dev#729:
|
As already stated in the PR header, "The change built fine with GCC 8 on RHEL 8 and java/awt/SplashScreen tests passed". |
|
OK, thanks. |
|
/approve yes |
|
@jerboaa |
|
Thanks. |
|
Going to push as commit 976d0a1. |
|
@gnu-andrew Pushed as commit 976d0a1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Update to the latest version of libpng. Change includes both the backport of the latest libpng change, JDK-8372534, and previous updates not present in 8u (JDK-8316030 - 1.6.40, JDK-8329004 - 1.6.43, JDK-8348598 - 1.6.47). The change built fine with GCC 8 on RHEL 8 and
java/awt/SplashScreentests passed.I also included
UPDATING.txtintroduced in JDK-8208353 in 11u, but not 8u, and updated in JDK-8295685 as part of the JDK-8329004 backport which updates it.I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/83/head:pull/83$ git checkout pull/83Update a local copy of the PR:
$ git checkout pull/83$ git pull https://git.openjdk.org/jdk8u.git pull/83/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 83View PR using the GUI difftool:
$ git pr show -t 83Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/83.diff
Using Webrev
Link to Webrev Comment