-
Notifications
You must be signed in to change notification settings - Fork 227
Close InputStream in case of exception #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ausing the file to remain open and breaking the GetSoundBankSecurityException test which immediately tries to delete it.
|
Hi @wasabii, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wasabii" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
|
|
@wasabii This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
InputStream not being closed on exception. Causes a test to fail under some conditions.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u.git pull/81/head:pull/81$ git checkout pull/81Update a local copy of the PR:
$ git checkout pull/81$ git pull https://git.openjdk.org/jdk8u.git pull/81/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 81View PR using the GUI difftool:
$ git pr show -t 81Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u/pull/81.diff