Skip to content

Conversation

@TimPushkin
Copy link

@TimPushkin TimPushkin commented Sep 1, 2025

Backport of JDK-8347911 for parity with Oracle's JDK 8u461.

Conflicts:

  • Copyright years
  • Missing JDK-8139206: use IOUtils.readNBytes(...) instead of the missing InputStream.readNBytes(...)

Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8347911 needs maintainer approval

Integration blocker

 ⚠️ Dependency #686 must be integrated first

Issue

  • JDK-8347911: Limit the length of inflated text chunks (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/687/head:pull/687
$ git checkout pull/687

Update a local copy of the PR:
$ git checkout pull/687
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 687

View PR using the GUI difftool:
$ git pr show -t 687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/687.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2025

👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into pr/686 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 398a580518b4e7961bdddf733e0a89ff25bc437a 8347911: Limit the length of inflated text chunks Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 1, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2025

Webrevs

@TimPushkin
Copy link
Author

I believe the test failures are not related

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TimPushkin
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Sep 30, 2025

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TimPushkin
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2025

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TimPushkin
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Nov 26, 2025

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2025

@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@TimPushkin
Copy link
Author

/touch

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset.

Backport-of: 398a580518b4e7961bdddf733e0a89ff25bc437a
@openjdk
Copy link

openjdk bot commented Dec 26, 2025

@TimPushkin this pull request can not be integrated into pr/686 due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8347911-jdk8
git fetch https://git.openjdk.org/jdk8u-dev.git pr/686
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/686"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Dec 26, 2025
@openjdk
Copy link

openjdk bot commented Dec 26, 2025

@TimPushkin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Dec 26, 2025
@TimPushkin
Copy link
Author

Rebased on top of the current master.

The CI failure is a single unrelated GC test, already reported as JDK-8303159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants