-
Notifications
You must be signed in to change notification settings - Fork 172
8347911: Limit the length of inflated text chunks #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: pr/686
Are you sure you want to change the base?
Conversation
|
👋 Welcome back tpushkin! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
I believe the test failures are not related |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@TimPushkin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@TimPushkin The pull request is being re-evaluated and the inactivity timeout has been reset. |
Backport-of: 398a580518b4e7961bdddf733e0a89ff25bc437a
3fd18e4 to
fd9a023
Compare
|
@TimPushkin this pull request can not be integrated into git checkout 8347911-jdk8
git fetch https://git.openjdk.org/jdk8u-dev.git pr/686
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge pr/686"
git push |
ab0f8cd to
83fa86f
Compare
|
@TimPushkin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
Rebased on top of the current master. The CI failure is a single unrelated GC test, already reported as JDK-8303159. |
Backport of JDK-8347911 for parity with Oracle's JDK 8u461.
Conflicts:
IOUtils.readNBytes(...)instead of the missingInputStream.readNBytes(...)Testing: GitHub CI, jdk_imageio test group locally (headless linux/arm64)
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/687/head:pull/687$ git checkout pull/687Update a local copy of the PR:
$ git checkout pull/687$ git pull https://git.openjdk.org/jdk8u-dev.git pull/687/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 687View PR using the GUI difftool:
$ git pr show -t 687Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/687.diff
Using Webrev
Link to Webrev Comment