Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 24, 2026

I backport this for parity with 25.0.3-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8374178 needs maintainer approval

Integration blocker

 ⚠️ Dependency #171 must be integrated first

Issue

  • JDK-8374178: Missing include in systemDictionary.cpp after JDK-8365526 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/172/head:pull/172
$ git checkout pull/172

Update a local copy of the PR:
$ git checkout pull/172
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/172/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 172

View PR using the GUI difftool:
$ git pr show -t 172

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/172.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 24, 2026

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 24, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@GoeLin GoeLin changed the base branch from master to pr/171 January 24, 2026 10:36
@GoeLin GoeLin changed the title Goetz backport 8374178 backport 9715e6da8355a103d9066bd15ce68b4773cbadcb Jan 24, 2026
@openjdk openjdk bot changed the title backport 9715e6da8355a103d9066bd15ce68b4773cbadcb 8374178: Missing include in systemDictionary.cpp after JDK-8365526 Jan 24, 2026
@openjdk
Copy link

openjdk bot commented Jan 24, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Jan 24, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 24, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant