Skip to content

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Jan 23, 2026


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8367862 needs maintainer approval

Issue

  • JDK-8367862: debug.cpp: Do not print help message for methods ifdef'd out (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/168.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2026

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 2f74e1433489bccf1fe493417715c0861f88a995 8367862: debug.cpp: Do not print help message for methods ifdef'd out Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2026

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant