Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Jan 22, 2026

Same as for JDK 26, fixes the regression in JDK 24.

Techinically not clean because there is a conflict in copyright line years, resolved in favor of incoming changeset.

Additional testing:

  • Linux x86_64 server fastdebug, new test case fails without the patch, passes with it
  • Linux x86_64 server fastdebug, tier1 with -XX:-CompactStrings

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8360271 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360271: String.indexOf intrinsics fail with +EnableX86ECoreOpts and -CompactStrings (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/165.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2026

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 22, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1d889b92bde5dfcb1fbe6cddb389a77f92eb1ce7 8360271: String.indexOf intrinsics fail with +EnableX86ECoreOpts and -CompactStrings Jan 22, 2026
@openjdk
Copy link

openjdk bot commented Jan 22, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jan 22, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2026

Webrevs

@shipilev
Copy link
Member Author

/approval request Same as for JDK 26, fixes the regression in JDK 24. Applies semi-cleanly (copyright year conflict, needs quick review, see RFR). New subtest catches fire without the fix, works with the fix. Other tests pass. Risk is on lower side: affects platforms with +EnableX86ECoreOpts enabled; we have already seen real-world cases due to this bug.

@openjdk
Copy link

openjdk bot commented Jan 22, 2026

@shipilev
8360271: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant