Skip to content

Conversation

@kdnilsen
Copy link
Contributor

@kdnilsen kdnilsen commented Jan 22, 2026

Hi all,

This pull request contains a backport of commit 385c4f81 from the openjdk/jdk repository.

The commit being backported was authored by Kelvin Nilsen on 8 Jan 2026 and was reviewed by William Kemper.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373714 needs maintainer approval

Issue

  • JDK-8373714: Shenandoah: Register heuristic penalties following a degenerated GC (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/162.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 22, 2026

👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 22, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 385c4f8180d30c0e41b848eb4b2c1c8788211422 8373714: Shenandoah: Register heuristic penalties following a degenerated GC Jan 22, 2026
@openjdk
Copy link

openjdk bot commented Jan 22, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jan 22, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 22, 2026

Webrevs

Comment on lines 76 to 79
virtual void record_cycle_start() override;
virtual void record_success_concurrent() override;
virtual void record_degenerated() override;
virtual void record_success_full() override;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So adding virtual in this hunk is what makes the backport unclean? Do you need to do it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove virtual and override from these declarations and the code still compiles on Linux with gcc 10.5.0.

My recollection is that certain other compilers (e.g. MacOS and/or Windows) are less forgiving, which is what motivated these changes in the original PR.

The GHA testing for backports is not as thorough as the GHA for changes to master.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, prefer clean backports.

I think you need to go to https://github.com/kdnilsen/jdk25u-dev/actions and enable GHA for your personal fork to get the GHA run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you enable GHA runs, you need to either trigger the run manually, or push a commit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants