-
Notifications
You must be signed in to change notification settings - Fork 30
8373714: Shenandoah: Register heuristic penalties following a degenerated GC #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8373714: Shenandoah: Register heuristic penalties following a degenerated GC #162
Conversation
|
👋 Welcome back kdnilsen! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
| virtual void record_cycle_start() override; | ||
| virtual void record_success_concurrent() override; | ||
| virtual void record_degenerated() override; | ||
| virtual void record_success_full() override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So adding virtual in this hunk is what makes the backport unclean? Do you need to do it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove virtual and override from these declarations and the code still compiles on Linux with gcc 10.5.0.
My recollection is that certain other compilers (e.g. MacOS and/or Windows) are less forgiving, which is what motivated these changes in the original PR.
The GHA testing for backports is not as thorough as the GHA for changes to master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, prefer clean backports.
I think you need to go to https://github.com/kdnilsen/jdk25u-dev/actions and enable GHA for your personal fork to get the GHA run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you enable GHA runs, you need to either trigger the run manually, or push a commit here.
Hi all,
This pull request contains a backport of commit 385c4f81 from the openjdk/jdk repository.
The commit being backported was authored by Kelvin Nilsen on 8 Jan 2026 and was reviewed by William Kemper.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/162/head:pull/162$ git checkout pull/162Update a local copy of the PR:
$ git checkout pull/162$ git pull https://git.openjdk.org/jdk25u-dev.git pull/162/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 162View PR using the GUI difftool:
$ git pr show -t 162Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/162.diff
Using Webrev
Link to Webrev Comment