Skip to content

Conversation

@parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Jan 21, 2026

Hi all,

This pull request contains a backport of commit d27649fe from the openjdk/jdk repository.

The commit being backported was authored by Johannes Bechberger on 8 Oct 2025 and was reviewed by David Holmes and Andrei Pangin.

The backported is not clean, because I had to resolve the removal of a test-related method that is no longer used and the problem list removal is no longer needed (the test has not been problem listed in JDK 25).

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8367302 needs maintainer approval
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #44 must be integrated first

Issue

  • JDK-8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/156/head:pull/156
$ git checkout pull/156

Update a local copy of the PR:
$ git checkout pull/156
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 156

View PR using the GUI difftool:
$ git pr show -t 156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/156.diff

Using Webrev

Link to Webrev Comment

@parttimenerd parttimenerd changed the title Backport d27649fe22a5bed9db72ac6c2595ac91f1fa28f8 8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing Jan 21, 2026
@parttimenerd
Copy link
Contributor Author

/approval request "Mostly clean backport of code that fixes the TestCPUTimeSampleQueueAutoSizes.java. Risks are minimal."

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2026

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into pr/44 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 21, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 21, 2026
@openjdk
Copy link

openjdk bot commented Jan 21, 2026

@parttimenerd
8367302: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 21, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2026

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Jan 23, 2026
@parttimenerd parttimenerd changed the title 8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing Backport d27649fe22a5bed9db72ac6c2595ac91f1fa28f8 Jan 23, 2026
@openjdk openjdk bot changed the title Backport d27649fe22a5bed9db72ac6c2595ac91f1fa28f8 8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants