-
Notifications
You must be signed in to change notification settings - Fork 30
8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32 #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
|
@wkia This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 55 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request I'd like to backport this to 25u-dev as jdk25 is affected as well. Clean backport. Test changes only. No risk. |
Webrevs
|
|
/integrate |
|
There is a bugtail: https://bugs.openjdk.org/browse/JDK-8373429 -- are you planning to backport that as well? |
|
I'm not going to backport this to 25, as far as I see it's labeled as "affected 26", not 25. |
Well, sure it does not affect 25, because it does not affect 25 until you do this backport! JDK-8373429 is the bugtail for this PR. |
|
@shipilev No problem then, I will backport JDK-8373429 as well with the next PR. |
|
I think it is worth mixing up two commits in this PR to avoid breakages in between commits. |
|
/issue add 8373429 |
|
@wkia |
shipilev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks right, thanks.
|
/approval JDK-8373429 request I'd like to backport this to 25u-dev as a part of fixing this test on linux-arm32. Clean backport. Test changes only. No risk. |
|
/integrate |
This PR contains clean backports of 8372860 and 8373429.
These changes are intended to make TestCodeCacheUnloadDuringConcCycle more stable on different platforms including linux-arm32.
Test changes only. No risk.
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/152/head:pull/152$ git checkout pull/152Update a local copy of the PR:
$ git checkout pull/152$ git pull https://git.openjdk.org/jdk25u-dev.git pull/152/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 152View PR using the GUI difftool:
$ git pr show -t 152Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/152.diff
Using Webrev
Link to Webrev Comment