Skip to content

Conversation

@wkia
Copy link

@wkia wkia commented Jan 16, 2026

This PR contains clean backports of 8372860 and 8373429.
These changes are intended to make TestCodeCacheUnloadDuringConcCycle more stable on different platforms including linux-arm32.
Test changes only. No risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8372860 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8373429 needs maintainer approval

Issues

  • JDK-8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32 (Bug - P4 - Approved)
  • JDK-8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/152/head:pull/152
$ git checkout pull/152

Update a local copy of the PR:
$ git checkout pull/152
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/152/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 152

View PR using the GUI difftool:
$ git pr show -t 152

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/152.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2026

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 16, 2026

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32
8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 6a6ff876c515eba6cc89320e02dc5739d4540316 8372860: TestCodeCacheUnloadDuringConcCycle fails on ARM32 Jan 16, 2026
@openjdk
Copy link

openjdk bot commented Jan 16, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 16, 2026
@openjdk
Copy link

openjdk bot commented Jan 16, 2026

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 16, 2026
@wkia
Copy link
Author

wkia commented Jan 16, 2026

/approval request I'd like to backport this to 25u-dev as jdk25 is affected as well. Clean backport. Test changes only. No risk.

@openjdk
Copy link

openjdk bot commented Jan 16, 2026

@wkia
8372860: The approval request has been created successfully.

@mlbridge
Copy link

mlbridge bot commented Jan 16, 2026

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored and removed approval Requires approval; will be removed when approval is received labels Jan 16, 2026
@openjdk
Copy link

openjdk bot commented Jan 16, 2026

@wkia
Your change (at version be08b03) is now ready to be sponsored by a Committer.

@wkia
Copy link
Author

wkia commented Jan 16, 2026

/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2026

@wkia
Your change (at version be08b03) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

There is a bugtail: https://bugs.openjdk.org/browse/JDK-8373429 -- are you planning to backport that as well?

@wkia
Copy link
Author

wkia commented Jan 19, 2026

@shipilev

https://bugs.openjdk.org/browse/JDK-8373429

I'm not going to backport this to 25, as far as I see it's labeled as "affected 26", not 25.

@shipilev
Copy link
Member

I'm not going to backport this to 25, as far as I see it's labeled as "affected 26", not 25.

Well, sure it does not affect 25, because it does not affect 25 until you do this backport! JDK-8373429 is the bugtail for this PR.

@wkia
Copy link
Author

wkia commented Jan 19, 2026

@shipilev No problem then, I will backport JDK-8373429 as well with the next PR.
Or do you want me to add that change to the current PR?

@shipilev
Copy link
Member

I think it is worth mixing up two commits in this PR to avoid breakages in between commits.

@openjdk openjdk bot removed clean Identical backport; no merge resolution required sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Jan 22, 2026
@wkia
Copy link
Author

wkia commented Jan 22, 2026

/issue add 8373429

@openjdk
Copy link

openjdk bot commented Jan 22, 2026

@wkia
Adding additional issue to issue list: 8373429: gc/g1/TestCodeCacheUnloadDuringConcCycle fails on various platforms.

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, thanks.

@wkia
Copy link
Author

wkia commented Jan 22, 2026

/approval JDK-8373429 request I'd like to backport this to 25u-dev as a part of fixing this test on linux-arm32. Clean backport. Test changes only. No risk.

@openjdk
Copy link

openjdk bot commented Jan 22, 2026

@wkia
JDK-8373429: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 22, 2026
@wkia
Copy link
Author

wkia commented Jan 23, 2026

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 23, 2026
@openjdk
Copy link

openjdk bot commented Jan 23, 2026

@wkia
Your change (at version 8e0a940) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored

Development

Successfully merging this pull request may close these issues.

2 participants