Skip to content

Conversation

@xiezhaokun
Copy link
Member

@xiezhaokun xiezhaokun commented Jan 14, 2026

tz2025c changes. clean backport of https://git.openjdk.org/jdk/commit/5df183be6c484d8f9635fac149caf5e2079c5561


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373476 needs maintainer approval

Issue

  • JDK-8373476: (tz) Update Timezone Data to 2025c (Enhancement - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/147/head:pull/147
$ git checkout pull/147

Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 147

View PR using the GUI difftool:
$ git pr show -t 147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/147.diff

Using Webrev

Link to Webrev Comment


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8373476 needs maintainer approval

Issue

  • JDK-8373476: (tz) Update Timezone Data to 2025c (Enhancement - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/147/head:pull/147
$ git checkout pull/147

Update a local copy of the PR:
$ git checkout pull/147
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 147

View PR using the GUI difftool:
$ git pr show -t 147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/147.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2026

👋 Welcome back zxie! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 14, 2026

@xiezhaokun This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot changed the title Backport 5df183be6c484d8f9635fac149caf5e2079c5561 8373476: (tz) Update Timezone Data to 2025c Jan 14, 2026
@openjdk
Copy link

openjdk bot commented Jan 14, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 14, 2026
@openjdk
Copy link

openjdk bot commented Jan 14, 2026

⚠️ @xiezhaokun This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 14, 2026
@xiezhaokun
Copy link
Member Author

/approval Request backport

@openjdk
Copy link

openjdk bot commented Jan 14, 2026

@xiezhaokun usage: /approval [<id>] (request|cancel) [<text>]

@xiezhaokun
Copy link
Member Author

/approval request backport

@mlbridge
Copy link

mlbridge bot commented Jan 14, 2026

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 14, 2026

@xiezhaokun
8373476: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 14, 2026
@GoeLin
Copy link
Member

GoeLin commented Jan 14, 2026

Hi @xiezhaokun
please have a look at https://wiki.openjdk.org/spaces/JDKUpdates/pages/42598906/How+to+contribute+or+backport+a+fix
especially part 6 about how to write a fix request comment.
You have broken tests here. What is wrong?

@xiezhaokun
Copy link
Member Author

/retest

@openjdk
Copy link

openjdk bot commented Jan 15, 2026

@xiezhaokun Unknown command retest - for a list of valid commands use /help.

@xiezhaokun
Copy link
Member Author

/help

@openjdk
Copy link

openjdk bot commented Jan 15, 2026

@xiezhaokun Available commands:

  • approval - request for maintainer's approval
  • approve - null
  • author - sets an overriding author to be used in the commit when the PR is integrated
  • backport - create a backport
  • cc - add or remove an additional classification label
  • clean - Mark the backport pull request as a clean backport
  • contributor - adds or removes additional contributors for a PR
  • covered - used when employer has signed the OCA
  • csr - require a compatibility and specification request (CSR) for this pull request
  • help - shows this text
  • integrate - performs integration of the changes in the PR
  • issue - edit the list of issues that this PR solves
  • jep - require a JDK Enhancement Proposal (JEP) for this pull request
  • keepalive - Re-evaluates the pull request and resets the inactivity timeout.
  • label - add or remove an additional classification label
  • open - Set the pull request state to "open"
  • reviewer - manage additional reviewers for a PR
  • reviewers - set the number of additional required reviewers for this PR
  • signed - used after signing the OCA
  • solves - edit the list of issues that this PR solves
  • sponsor - performs integration of a PR that is authored by a non-committer
  • summary - updates the summary in the commit message
  • test - used to run tests
  • touch - Re-evaluates the pull request and resets the inactivity timeout.

For additional details, see Pull Request Commands documentation

@GoeLin
Copy link
Member

GoeLin commented Jan 16, 2026

Hi @xiezhaokun
still I would like to know what was wrong.
Is this a sporadic issue caused by the change?

@xiezhaokun
Copy link
Member Author

Hi @xiezhaokun still I would like to know what was wrong. Is this a sporadic issue caused by the change?

I suspected it was a network problem, but the problem didn't occur after I tried again.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 20, 2026
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this is a clean patch.
What testing has been run?
For tzdata changes, I would expect tests to be run that are not part of tier1:

make run-test TEST="jtreg:java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources"

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed ready Pull request is ready to be integrated labels Jan 22, 2026
@gnu-andrew
Copy link
Member

I've revoked approval until there is evidence of sufficient testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants