Skip to content

Conversation

@rgithubli
Copy link
Contributor

@rgithubli rgithubli commented Jan 13, 2026

Backport of JDK-8358529. Bug fix, so heuristics respects soft max heap size.

Testing: GHA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8358529 needs maintainer approval

Issue

  • JDK-8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/143/head:pull/143
$ git checkout pull/143

Update a local copy of the PR:
$ git checkout pull/143
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/143/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 143

View PR using the GUI difftool:
$ git pr show -t 143

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/143.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2026

👋 Welcome back rgithubli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 13, 2026

@rgithubli This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport fa32bfe11300fdadb35f083037f6ab2a8985d210 8358529: GenShen: Heuristics do not respond to changes in SoftMaxHeapSize Jan 13, 2026
@openjdk
Copy link

openjdk bot commented Jan 13, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jan 13, 2026
@rgithubli rgithubli marked this pull request as ready for review January 20, 2026 19:24
@rgithubli
Copy link
Contributor Author

rgithubli commented Jan 20, 2026

/approval

@rgithubli rgithubli closed this Jan 20, 2026
@openjdk
Copy link

openjdk bot commented Jan 20, 2026

@rgithubli usage: /approval [<id>] (request|cancel) [<text>]

@rgithubli
Copy link
Contributor Author

/approval request Backport of JDK-8358529. Bug fix, so generational shenandoah heuristics can respect soft max heap size.

Testing: GHA.

@rgithubli rgithubli reopened this Jan 20, 2026
@openjdk
Copy link

openjdk bot commented Jan 20, 2026

⚠️ @rgithubli This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2026
@openjdk
Copy link

openjdk bot commented Jan 20, 2026

@rgithubli
8358529: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jan 20, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2026

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant