8365976: G1: Full gc should mark nmethods on stack #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting JDK-8365976: G1: Full gc should mark nmethods on stack.
This PR fixes a regression introduced by JDK-8360540 where full GC stopped marking nmethods on the stack, potentially causing premature code eviction. The fix moves nmethod arming to occur after nmethod registration during full GC, ensuring that nmethods remaining after collection are properly armed and protected from inappropriate eviction.
This depends on #140
This backport has internal demand.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/vmTestbase/gc
Results attached:
linux-aarch64-specific-test.log
linux-x64-specific-test.log
macos-aarch64-specific-test.log
windows-x64-specific-test.log
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/142/head:pull/142$ git checkout pull/142Update a local copy of the PR:
$ git checkout pull/142$ git pull https://git.openjdk.org/jdk25u-dev.git pull/142/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 142View PR using the GUI difftool:
$ git pr show -t 142Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/142.diff
Using Webrev
Link to Webrev Comment