-
Notifications
You must be signed in to change notification settings - Fork 30
8369611: Remove safepoint synchronization from ParallelScavengeHeap and SerialHeap #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8369611: Remove safepoint synchronization from ParallelScavengeHeap and SerialHeap This PR removes unnecessary conditional STS (Safepoint Thread Synchronization) code from ParallelScavengeHeap and SerialHeap. This backport has internal demand. Low risk - Fix is based on previous architectural change (JDK-8369392) with known implications, though any change to safepoint synchronization could affect GC pause times or thread coordination. |
|
Hi Roland, |
|
Hi Goetz, The earliest opportunity that meets the maintainers (and product) quality gates would be preferable. |
|
This one is one the simpler side, so we can have it in April release, I think? More complicated ones can indeed go into July release. |
Backporting JDK-8369611: Remove safepoint synchronization from ParallelScavengeHeap and SerialHeap
This PR removes unnecessary conditional STS (Safepoint Thread Synchronization) code from ParallelScavengeHeap and SerialHeap. The cleanup is possible because StringDedup threads are now derived from JavaThread (changed in JDK-8369392), eliminating the need for special conditional synchronization logic that was previously required when StringDedup threads had different threading characteristics.
This backport has internal demand.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/vmTestbase/gc
Results attached:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/136/head:pull/136$ git checkout pull/136Update a local copy of the PR:
$ git checkout pull/136$ git pull https://git.openjdk.org/jdk25u-dev.git pull/136/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 136View PR using the GUI difftool:
$ git pr show -t 136Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/136.diff
Using Webrev
Link to Webrev Comment