Skip to content

feat: add optional fullscreen button to Modal#4118

Open
rpenido wants to merge 1 commit intoopenedx:release-23.xfrom
open-craft:rpenido/fal-4321/add-fullscreen-button
Open

feat: add optional fullscreen button to Modal#4118
rpenido wants to merge 1 commit intoopenedx:release-23.xfrom
open-craft:rpenido/fal-4321/add-fullscreen-button

Conversation

@rpenido
Copy link
Contributor

@rpenido rpenido commented Feb 10, 2026

Description

This PR introduces an optional Fullscreen button on the ModalDialog class to enable users to toggle full-screen mode.

test

Deploy Preview

https://deploy-preview-4118--paragon-openedx-v23.netlify.app/components/modal/modal-dialog/

Additional Info

This PR is part of an initiative to improve the UI for xblock editors with many configuration options.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 10, 2026
@netlify
Copy link

netlify bot commented Feb 10, 2026

Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 65fc4a7
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/698bae1fe0278d000809f7d3
😎 Deploy Preview https://deploy-preview-4118--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 10, 2026

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.40%. Comparing base (dfc69e2) to head (65fc4a7).
⚠️ Report is 5 commits behind head on release-23.x.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-23.x    #4118      +/-   ##
================================================
+ Coverage         94.39%   94.40%   +0.01%     
================================================
  Files               242      242              
  Lines              4296     4304       +8     
  Branches           1020      987      -33     
================================================
+ Hits               4055     4063       +8     
  Misses              237      237              
  Partials              4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rpenido rpenido force-pushed the rpenido/fal-4321/add-fullscreen-button branch 3 times, most recently from fd47f8d to e38ac5e Compare February 10, 2026 19:47
@rpenido rpenido force-pushed the rpenido/fal-4321/add-fullscreen-button branch from e38ac5e to 65fc4a7 Compare February 10, 2026 22:15
@rpenido rpenido marked this pull request as ready for review February 13, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants