feat: add optional fullscreen button to Modal#4118
feat: add optional fullscreen button to Modal#4118rpenido wants to merge 1 commit intoopenedx:release-23.xfrom
Conversation
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4118 +/- ##
================================================
+ Coverage 94.39% 94.40% +0.01%
================================================
Files 242 242
Lines 4296 4304 +8
Branches 1020 987 -33
================================================
+ Hits 4055 4063 +8
Misses 237 237
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd47f8d to
e38ac5e
Compare
e38ac5e to
65fc4a7
Compare
Description
This PR introduces an optional Fullscreen button on the
ModalDialogclass to enable users to toggle full-screen mode.Deploy Preview
https://deploy-preview-4118--paragon-openedx-v23.netlify.app/components/modal/modal-dialog/
Additional Info
This PR is part of an initiative to improve the UI for xblock editors with many configuration options.
Merge Checklist
exampleapp?Post-merge Checklist