Skip to content

feat: store content.child_usage_keys in Container search document [FC-0083] [TEAK] #36651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
navinkarkera merged 1 commit into from
May 2, 2025
Merged

feat: store content.child_usage_keys in Container search document [FC-0083] [TEAK] #36651

navinkarkera merged 1 commit into from
May 2, 2025

Conversation

@pomegranited
Copy link
Contributor

@pomegranited pomegranited commented May 2, 2025

Description

Backports #36528 to Teak.

Supporting information

Part of: openedx/frontend-app-authoring#1778
Addresses this comment: https://github.com/openedx/edx-platform/pull/36477/files#r2033737978
Private-ref: FAL-4139

Testing instructions

See #36528

Deadline

ASAP

@pomegranited
feat: store content.child_usage_keys in Container search document [FC…
9886e11 
…-0083] (openedx#36528)

* feat: store content.child_usage_keys in Container search document
  Stores the draft children + published children (if applicable)

Related fixes:
* fix: lib_api.get_container does not take a "user" arg
* refactor: fetch_customizable_fields_from_container does not need a "user" arg
* refactor: moves tags_count into LibraryItem
   because anything that appears in a library may be tagged.
* refactor: remove get_container_from_key from public API
   API users must use get_container and ContainerMetadata.
* refactor: made set_library_item_collections take an entity_key string instead of
  a PublishableEntity instance, so we don't need to fetch a Container object to call it.
* refactor: changed ContainerLink.update_or_create to take the container PK
  instead of a Container object, since this is enough.
  Added container_pk to ContainerMetadata to support this.

(cherry picked from commit 5b3caa9)
@openedx-webhooks
Copy link

openedx-webhooks commented May 2, 2025

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 2, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions May 2, 2025
@pomegranited pomegranited mentioned this pull request May 2, 2025
Merged
navinkarkera
navinkarkera approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomegranited Thanks! 👍

  • I tested this: (Tested in master branch and verified cherry picked commit and files)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@navinkarkera
Copy link
Contributor

navinkarkera commented May 2, 2025

@farhaanbukhsh FYI on backport fix

@navinkarkera navinkarkera merged commit 45ed39d into openedx:release/teak.master May 2, 2025
48 checks passed
@navinkarkera navinkarkera deleted the jill/teak/content-search-unit-blocks branch May 2, 2025 06:00
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@navinkarkera navinkarkera navinkarkera approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pomegranited @openedx-webhooks @navinkarkera