refactor!: use LibraryCollectionLocator and LibraryContainerLocator [FC-0083]

[pomegranited]

Description

Refactors the content_libraries.api to use LibraryCollectionLocator and LibraryContainerLocator keys, instead of passing separate LibraryUsageKeyV2 keys along with the collection/container locators.

Renames misleading uses of collection_usage_key to collection_locator, including in the content_libraries.api and content.search.api method names and parameters.

This change impacts Developers, but should not affect end users.

This refactoring seems reasonable to do without going through deprecation, given the minimal use of these APIs.

Supporting information

cf openedx/openedx-events#479 (comment)
Blocked by: openedx/openedx-events#487 (merged)
Private-ref: FAL-4120

Testing instructions

Code review + CI should be sufficient for verifying this change.

Manual testing with the Authoring MFE:

• Ensure you can create, update, and delete library collections, and that these changes show up as expected in the MFE.
• Repeat ^ for containers (update and delete may not be available yet)

Deadline

ASAP -- want to get this in before Teak.

[openedx-webhooks]

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[rpenido]

LGTM 👍
Thank you for your work, @pomegranited!

• I tested this using the CI pipeline
• I read through the code
• I checked for accessibility issues
• Includes documentation

Let me know if you want another check after merging and fixing the conflicts!

[ChrisChV]

@pomegranited When creating a Unit, I got this error:

cms-1               | Traceback (most recent call last):
cms-1               |   File "/openedx/venv/lib/python3.11/site-packages/celery/app/trace.py", line 453, in trace_task
cms-1               |     R = retval = fun(*args, **kwargs)
cms-1               |                  ^^^^^^^^^^^^^^^^^^^^
cms-1               |   File "/openedx/venv/lib/python3.11/site-packages/celery/app/autoretry.py", line 38, in run
cms-1               |     return task._orig_run(*args, **kwargs)
cms-1               |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cms-1               |   File "/openedx/venv/lib/python3.11/site-packages/edx_django_utils/monitoring/internal/code_owner/utils.py", line 195, in new_function
cms-1               |     return wrapped_function(*args, **kwargs)
cms-1               |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
cms-1               |   File "/openedx/edx-platform/openedx/core/djangoapps/content/search/tasks.py", line 128, in update_library_container_index_doc
cms-1               |     library_key = container_key.library_key
cms-1               |                   ^^^^^^^^^^^^^^^^^^^^^^^^^
cms-1               | AttributeError: 'str' object has no attribute 'library_key'

[pomegranited]

When creating a Unit, I got this error:

Thank you for catching this @ChrisChV ! My last-minute 71afe3f caused this problem, so have fixed with c4329ee. Can you please re-test?

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.