Skip to content

feat: Discussion event extraction, in openedx-event library #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JuanDavidBuitrago merged 1 commit into from
Feb 23, 2022
Merged

feat: Discussion event extraction, in openedx-event library #45

JuanDavidBuitrago merged 1 commit into from
Feb 23, 2022

Conversation

@JuanDavidBuitrago
Copy link
Contributor

@JuanDavidBuitrago JuanDavidBuitrago commented Feb 14, 2022 •
edited
Loading

Description:
This PR extract the definition of COURSE_DISCUSSIONS_CHANGED event and his attr data from edx-platform to openedx-events library.

Testing instructions:

  1. In studio, modified the content of a course in a unit and publish changes
  2. You should see new DiscussionTopicLink objects, one for each general topic and one for each unit.
  3. In studio logs you can see log.info for "Updating existing discussion topic links for" or "Creating new discussion topic links for"
  4. In django admin you can see DiscussionsConfiguration in change discussions configuration

Support information:
PRs merge in openedx/edx-platform

Merge checklist:

  • Reviewers approved
  • Commits are squashed

Post merge:

  • Create a tag
  • Delete working branch (if not needed anymore)

Author concerns:
None for now.

@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/event-extraction-discussions_update branch 4 times, most recently from 1709be7 to d3dccc0 Compare February 14, 2022 22:40
@JuanDavidBuitrago JuanDavidBuitrago marked this pull request as ready for review February 15, 2022 13:21
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Feb 15, 2022

Please, fix the length of the PR name

mariajgrimaldi
mariajgrimaldi reviewed Feb 15, 2022
View reviewed changes
mariajgrimaldi
mariajgrimaldi reviewed Feb 15, 2022
View reviewed changes
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/event-extraction-discussions_update branch from d3dccc0 to c9b70d6 Compare February 15, 2022 14:32
@JuanDavidBuitrago JuanDavidBuitrago changed the title feat: Discussion event extraction, from edx-platform to openedx-event… feat: Discussion event extraction, in openedx-event library Feb 15, 2022
@JuanDavidBuitrago
Copy link
Contributor Author

JuanDavidBuitrago commented Feb 15, 2022

Please, fix the length of the PR name

Done!!!

felipemontoya
felipemontoya reviewed Feb 15, 2022
View reviewed changes
@JuanDavidBuitrago JuanDavidBuitrago mentioned this pull request Feb 15, 2022
Merged
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/event-extraction-discussions_update branch from c9b70d6 to 277c8b6 Compare February 23, 2022 12:40
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/event-extraction-discussions_update branch from 277c8b6 to 1c1d28a Compare February 23, 2022 13:20
mariajgrimaldi
mariajgrimaldi reviewed Feb 23, 2022
View reviewed changes
mariajgrimaldi
mariajgrimaldi requested changes Feb 23, 2022
View reviewed changes
@JuanDavidBuitrago JuanDavidBuitrago force-pushed the JDB/event-extraction-discussions_update branch from 1c1d28a to f93fb2b Compare February 23, 2022 14:35
mariajgrimaldi
mariajgrimaldi approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@JuanDavidBuitrago JuanDavidBuitrago merged commit 20688f1 into main Feb 23, 2022
@JuanDavidBuitrago JuanDavidBuitrago deleted the JDB/event-extraction-discussions_update branch February 23, 2022 21:51
@JuanDavidBuitrago JuanDavidBuitrago restored the JDB/event-extraction-discussions_update branch February 25, 2022 16:38
@mariajgrimaldi mariajgrimaldi mentioned this pull request Mar 2, 2022
Merged
9 tasks
@mariajgrimaldi mariajgrimaldi deleted the JDB/event-extraction-discussions_update branch August 31, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felipemontoya felipemontoya felipemontoya approved these changes

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

+1 more reviewer

@xitij2000 xitij2000 xitij2000 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JuanDavidBuitrago @mariajgrimaldi @xitij2000 @felipemontoya