Skip to content

Conversation

@IvanStepanok
Copy link
Contributor

@IvanStepanok IvanStepanok commented Mar 31, 2025

App Level Dates

Dark theme Light theme
Simulator Screenshot - iPhone 16 Pro - 2025-04-03 at 16 25 20 Simulator Screenshot - iPhone 16 Pro - 2025-04-03 at 16 25 24

Landscape mode


Simulator Screenshot - iPhone 16 Pro - 2025-04-03 at 16 25 28

iPad


Simulator Screenshot - iPad Air 11-inch (M3) - 2025-04-03 at 16 27 51

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 31, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Mar 31, 2025

Thanks for the pull request, @IvanStepanok!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 1, 2025
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 8, 2025
@IvanStepanok IvanStepanok marked this pull request as ready for review December 24, 2025 11:47
@edschema edschema requested review from RawanMatar89 and removed request for RawanMatar89 December 26, 2025 18:08
@edschema
Copy link

Can I request some color changes?

  • can we change the subtitle (course title) text color to match the date color?

left bar colors:
Past due: yellow (as shown), This week: Accent (blue), Next week: secondary dark, Future: light

Grouping Theme Color
Past Due Light warning (yellow)
Past Due Dark warning (yellow)
This week Light Accent (blue)
This week Dark Accent (blue)
Next week Light light dark (gray)
Next week Dark light dark (gray)
Upcoming Light light (lighter gray)
Upcoming Dark half dark (darker gray)

We can keep put these changes as a future change request too if absolutely necessary, but I think it's much easier to fix here.

@edschema edschema requested a review from RawanMatar89 January 6, 2026 16:07
@IvanStepanok
Copy link
Contributor Author

Design updates confirmed by @edschema

Screen.Recording.2026-01-06.at.6.47.27.PM.mov
Screenshot 2026-01-07 at 12 12 20 PM

@IvanStepanok
Copy link
Contributor Author

@RawanMatar89 Need your review, please 🙏

@RawanMatar89
Copy link
Contributor

@RawanMatar89 Need your review, please 🙏

@IvanStepanok sure, I'll do my best to finish it tomorrow.

@RawanMatar89
Copy link
Contributor

@IvanStepanok, could you please share the feature materials like design, specifications, or any related docs. I'd like to be fully understand the scope of this feature, since it introduces a new module

@IvanStepanok
Copy link
Contributor Author

@IvanStepanok, could you please share the feature materials like design, specifications, or any related docs. I'd like to be fully understand the scope of this feature, since it introduces a new module

Sure. There is a Figma: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/%F0%9F%93%B1Mobile-App-v2.5--Open-edX-?node-id=14160-129389&t=TRcXkb5vUQBem4rg-4

Logic is simple: display all the dates from all the courses and have the ability to shift past due dates.

Copy link
Contributor

@RawanMatar89 RawanMatar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanStepanok
Thanks for your efforts and helpful discussions on slack 🙏🏻
the overall structure and code aligns well with the existing pattern.

just one important notice from my side that is tapping on a date cause the course screen content pushed twice! please check the attached recording.

LGTM once this is addressed 👍🏻👏🏻

Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-01-15.at.11.05.15.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

6 participants