-
Notifications
You must be signed in to change notification settings - Fork 24
feat: [FC-0078] app level dates #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @IvanStepanok! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Fix/issue 581
|
Can I request some color changes?
left bar colors:
We can keep put these changes as a future change request too if absolutely necessary, but I think it's much easier to fix here. |
|
Design updates confirmed by @edschema Screen.Recording.2026-01-06.at.6.47.27.PM.mov
|
|
@RawanMatar89 Need your review, please 🙏 |
@IvanStepanok sure, I'll do my best to finish it tomorrow. |
|
@IvanStepanok, could you please share the feature materials like design, specifications, or any related docs. I'd like to be fully understand the scope of this feature, since it introduces a new module |
Sure. There is a Figma: https://www.figma.com/design/iZ56YMjbRMShCCDxqrqRrR/%F0%9F%93%B1Mobile-App-v2.5--Open-edX-?node-id=14160-129389&t=TRcXkb5vUQBem4rg-4 Logic is simple: display all the dates from all the courses and have the ability to shift past due dates. |
RawanMatar89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IvanStepanok
Thanks for your efforts and helpful discussions on slack 🙏🏻
the overall structure and code aligns well with the existing pattern.
just one important notice from my side that is tapping on a date cause the course screen content pushed twice! please check the attached recording.
LGTM once this is addressed 👍🏻👏🏻

App Level Dates
Landscape mode
iPad