Skip to content

fix: correct script paths #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgu-taylor-payne wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct script paths #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"/types.ts"
],
"bin": {
"intl-imports.js": "tools/dist/cli/scripts/intl-imports.js",
"intl-imports.js": "tools/dist/cli/intl-imports.js",
"openedx": "tools/dist/cli/openedx.js",
"transifex-utils.js": "tools/dist/cli/scripts/transifex-utils.js"
"transifex-utils.js": "tools/dist/cli/transifex-utils.js"
},
"scripts": {
"build": "make build",
Expand Down
4 changes: 2 additions & 2 deletions test-site/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions tools/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
# i18n/scripts
# cli

This directory contains the `transifex-utils.js` and `intl-imports.js` files which are shared across all micro-frontends.

The package.json of `frontend-base` includes the following sections:

```
"bin": {
"intl-imports.js": "i18n/scripts/intl-imports.js"
"transifex-utils.js": "i18n/scripts/transifex-utils.js"
"intl-imports.js": "tools/dist/cli/intl-imports.js",
"openedx": "tools/dist/cli/openedx.js",
"transifex-utils.js": "tools/dist/cli/transifex-utils.js"
},
```

This config block causes boths scripts to be copied to the following path when `frontend-base` is installed as a
This config block causes the scripts to be copied to the following path when `frontend-base` is installed as a
dependency of a micro-frontend:

```
/node_modules/.bin/intl-imports.js
/node_modules/.bin/openedx
/node_modules/.bin/transifex-utils.js
```

Expand All @@ -26,4 +28,4 @@ intl_imports = ./node_modules/.bin/intl-imports.js
transifex_utils = ./node_modules/.bin/transifex-utils.js
```

So if you delete either of the files or the `scripts` directory, you'll break all micro-frontend builds. Happy coding!
So if you delete either of the files or the `cli` directory, you'll break all micro-frontend builds. Happy coding!
Loading