feat: Add support for the new Open edX discussion provider [BD-38] [TNL-8622]

[xitij2000]

This adds support for configuring the new Open edX discussion provider. It expands on the features of the legacy configuration by adding additional ways to configure discussions.

Depends on: openedx/edx-platform#29863

[openedx-webhooks]

Thanks for the pull request, @xitij2000! I've created BLENDED-1012 to keep track of it in Jira. More details are on the BD-38 project page.

When this pull request is ready, tag your edX technical lead.

[codecov-commenter]

Codecov Report

Merging #217 (c03e807) into master (10b9803) will increase coverage by 0.13%.
The diff coverage is 84.21%.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   66.27%   66.41%   +0.13%     
==========================================
  Files          93       93              
  Lines        1699     1706       +7     
  Branches      376      385       +9     
==========================================
+ Hits         1126     1133       +7     
+ Misses        548      547       -1     
- Partials       25       26       +1     

Impacted Files	Coverage Δ
...fig-form/apps/shared/InContextDiscussionFields.jsx	66.66% <0.00%> (+66.66%)	⬆️
...-resources/discussions/app-config-form/messages.js	100.00% <ø> (ø)
...ges-and-resources/discussions/app-list/messages.js	100.00% <ø> (ø)
src/pages-and-resources/discussions/data/thunks.js	100.00% <ø> (ø)
...rces/discussions/app-config-form/AppConfigForm.jsx	97.14% <50.00%> (-2.86%)	⬇️
src/pages-and-resources/discussions/data/api.js	89.24% <66.66%> (-2.71%)	⬇️
...app-config-form/apps/openedx/OpenedXConfigForm.jsx	83.33% <100.00%> (ø)
...ig-form/apps/openedx/OpenedXConfigFormProvider.jsx	100.00% <100.00%> (ø)
...-config-form/apps/shared/DivisionByGroupFields.jsx	64.70% <100.00%> (ø)
...apps/shared/discussion-topics/DiscussionTopics.jsx	100.00% <100.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b9803...c03e807. Read the comment docs.

[Cup0fCoffee]

👍

The only problem I noticed is that "Group in context discussion at the subsection level" setting doesn't show the value that is saved, i.e. whenever you go to edit the settings, it will be set to off, even if it's on. It seems to be a problem with the backend not returning the value for the setting, so not related to the changes in this PR.

Also, to test the changes, I had to enabled the edx provider by modifying openedx/core/djangoapps/discussions/models.py.

• I tested this
• I read through the code
• [?] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

[xitij2000]

The only problem I noticed is that "Group in context discussion at the subsection level" setting doesn't show the value that is saved, i.e. whenever you go to edit the settings, it will be set to off, even if it's on. It seems to be a problem with the backend not returning the value for the setting, so not related to the changes in this PR.

I've fixed this issue and made some other changes to the API. It seems there might be some discussion about this so might need to pause this for a bit.

[mehaknasir]

just a suggestion marked on the code. otherwise changes looks fine to me

[xitij2000]

@mehaknasir This PR requires the edx-platform PR which currently cannot be merged since the API approach is in discussion. So I'm going to hold off on changes here till it's mergable.

[awaisdar001]

@xitij2000 Dep PR is closed, can you update the PR description to add a new PR link that this PR is depending upon?

thanks.

[xitij2000]

@xitij2000 Dep PR is closed, can you update the PR description to add a new PR link that this PR is depending upon?

thanks.

Done.

[codecov]

Codecov Report

Merging #217 (e2d8053) into master (95fdd37) will decrease coverage by 1.39%.
The diff coverage is 93.18%.

❗ Current head e2d8053 differs from pull request most recent head 0ac5e2e. Consider uploading reports for the commit 0ac5e2e to get more accurate results

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
- Coverage   67.95%   66.55%   -1.40%     
==========================================
  Files          94       94              
  Lines        1713     1743      +30     
  Branches      384      398      +14     
==========================================
- Hits         1164     1160       -4     
- Misses        524      557      +33     
- Partials       25       26       +1     

Impacted Files	Coverage Δ
...fig-form/apps/shared/InContextDiscussionFields.jsx	66.66% <0.00%> (+66.66%)	⬆️
...-resources/discussions/app-config-form/messages.js	100.00% <ø> (ø)
...ges-and-resources/discussions/app-list/messages.js	100.00% <ø> (ø)
src/pages-and-resources/discussions/data/api.js	89.32% <86.66%> (-2.82%)	⬇️
...rces/discussions/app-config-form/AppConfigForm.jsx	97.50% <88.88%> (-2.50%)	⬇️
...-and-resources/discussions/DiscussionsSettings.jsx	96.77% <100.00%> (ø)
...ussions/app-config-form/apps/lti/LtiConfigForm.jsx	92.50% <100.00%> (+2.25%)	⬆️
...app-config-form/apps/openedx/OpenedXConfigForm.jsx	83.33% <100.00%> (ø)
...ig-form/apps/openedx/OpenedXConfigFormProvider.jsx	100.00% <100.00%> (ø)
...-config-form/apps/shared/DivisionByGroupFields.jsx	67.64% <100.00%> (ø)
... and 22 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fdd37...0ac5e2e. Read the comment docs.

[Cup0fCoffee]

@xitij2000 "Group in context discussion at the subsection level" always displays false. The value comes back from the API, but gets lost during normalization.
I was able to fix it by adding groupAtSubsection: data.group_at_subsection here. Idk if it's where it is intended to be.

[Cup0fCoffee]

👍 Minor changes required.

• I tested this
• I read through the code

[openedx-webhooks]

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.