-
Notifications
You must be signed in to change notification settings - Fork 52
Feat/multi org based course filter #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/multi org based course filter #237
Conversation
|
Thanks for the pull request, @kemalatgithub! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @kemalatgithub! Could you take a look at resolving the branch conflicts? Then we can review. Thanks! |
enabling modern JSON-style payloads. It also correctly processes multiple values per key, producing clean, predictable lists. This makes aligned with the multiple organization based course filtering features planned in these PR.
…s,enabling modern JSON-style payloads. It also correctly processes multiple values per key, producing clean, predictable lists. This makes aligned with the multiple organization based course filtering features planned in these PR.
…base file updated. - search/filter_generator.py - search/views.py
03b4749 to
934cbd7
Compare
|
@kemalatgithub Can you please resolve the conflicts on this branch? Thanks! |
|
@kemalatgithub Also note the existing failed checks. I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard? |
Flagging this for you, @kemalatgithub |
This PR re-opens the work from Feat/multi-org based filter (#236), which was closed unexpectedly.
No functional changes have been added — this PR simply restores the previous work with the reviewer-requested changes and comments have been fully incorporated so the feature can move forward through review and merging.