Skip to content

Conversation

@kemalatgithub
Copy link

This PR re-opens the work from Feat/multi-org based filter (#236), which was closed unexpectedly.
No functional changes have been added — this PR simply restores the previous work with the reviewer-requested changes and comments have been fully incorporated so the feature can move forward through review and merging.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 17, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @kemalatgithub!

This repository is currently maintained by @Ali-Salman29.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 17, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 19, 2025
@mphilbrick211
Copy link

Hi @kemalatgithub! Could you take a look at resolving the branch conflicts? Then we can review. Thanks!

enabling modern JSON-style payloads. It also correctly processes multiple
values per key, producing clean, predictable lists. This makes aligned with
the multiple organization based course filtering features planned in these PR.
…s,enabling modern JSON-style payloads.

It also correctly processes multiple values per key, producing clean, predictable lists.
This makes aligned with the multiple organization based course filtering features planned in these PR.
…base file updated.

- search/filter_generator.py
- search/views.py
@kemalatgithub kemalatgithub force-pushed the feat/multi-org_based_course_filter branch from 03b4749 to 934cbd7 Compare November 20, 2025 06:18
@farhaanbukhsh farhaanbukhsh self-requested a review November 29, 2025 09:20
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 12, 2025
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Needs Tests Run or CLA Signed in Contributions Dec 12, 2025
@e0d
Copy link

e0d commented Dec 19, 2025

@kemalatgithub Can you please resolve the conflicts on this branch? Thanks!

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 19, 2025
@e0d e0d moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Dec 19, 2025
@e0d
Copy link

e0d commented Dec 19, 2025

@kemalatgithub Also note the existing failed checks.

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

@mphilbrick211
Copy link

@kemalatgithub Also note the existing failed checks.

I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

Flagging this for you, @kemalatgithub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

4 participants