Skip to content

Conversation

@tumbledwyer
Copy link
Contributor

@tumbledwyer tumbledwyer commented Jan 7, 2026

Description

Addresses with null values in streetLevelDetails were incorrectly being picked up as changed when they are effectively the same value.

Fixes: #11122 (comment)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Addresses with null values in streetLevelDetails were incorrectly being picked up as changed when they are effectively the same
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

📊 commons test coverage

Statements: 67.18%
Branches:   33.23%
Functions:  50.25%
Lines:      66.59%
Updated at: Fri, 09 Jan 2026 07:49:09 GMT

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

📊 events test coverage

Statements: 85.02%
Branches:   83.99%
Functions:  90.47%
Lines:      85.02%
Updated at: Fri, 09 Jan 2026 07:53:58 GMT

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-11122.e2e-k8s.opencrvs.dev

@tumbledwyer tumbledwyer merged commit 0b21595 into develop Jan 9, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Updated' modal missing after migration.

4 participants