Skip to content

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Dec 22, 2025

Fixes #347.

Copilot AI review requested due to automatic review settings December 22, 2025 04:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-enables Windows code signing in the CD (Continuous Deployment) workflow after the EV certificate was renewed, addressing issue #347. The changes restore the ability to sign Windows binaries during the automated build and release process.

Key changes:

  • Re-enabled Windows EV certificate retrieval and code signing steps
  • Updated version numbers to 0.20251222.0
  • Updated @wasm-fmt/clang-format dependency from 21.1.6 to 21.1.7

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/cd.yml Uncommented Windows code signing environment variables and certificate retrieval steps to restore code signing functionality; also includes unintended commented-out sections for release steps and jobs
package.json Updated version to 0.20251222.0 and bumped @wasm-fmt/clang-format to 21.1.7
src/renderer/package.json Updated version to 0.20251222.0
bun.lock Updated lockfile to reflect @wasm-fmt/clang-format version change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny force-pushed the issue347 branch 5 times, most recently from 7eb60d6 to d2e59bf Compare December 22, 2025 05:31
@agarny agarny merged commit dd8f923 into opencor:main Dec 22, 2025
8 checks passed
@agarny agarny deleted the issue347 branch December 22, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CD: reenable code signing on Windows

1 participant