feat: display total skills count on /skills page

[rknoche6]

• Added countPublicSkills query to convex/skills.ts
• Updated SkillsIndex to fetch and display the count
• Fixed missing undici dependency for e2e tests
• Applied biome formatting

Greptile Overview

Greptile Summary

This PR adds a new Convex query (countPublicSkills) and wires it into the /skills route to display a total count in the page header. It also adds undici as a dev dependency (and updates bun.lock) to fix missing dependency issues in e2e tests, and applies a small Biome-driven import reordering in src/lib/og.ts.

Main integration point is src/routes/skills/index.tsx, which now calls useQuery(api.skills.countPublicSkills) alongside the existing paginated public skills query to show the total.

Confidence Score: 3/5

• This PR is likely safe to merge, but the new count query can become a scalability bottleneck as data grows.
• UI change is small and dependency addition is straightforward, but countPublicSkills currently loads all active skills into memory to count them, which can degrade performance and potentially hit Convex query limits on larger datasets since it’s fetched on every /skills page load.
• convex/skills.ts (countPublicSkills implementation)

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

Context used:

• Context from dashboard - AGENTS.md (source)

[vercel]

@rknoche is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.

[greptile-apps]

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

[P1] countPublicSkills does a full .collect() and then returns skills.length, which will scan and materialize every active skill doc. On larger datasets this will be slow and can hit Convex limits, especially since /skills mounts it unconditionally via useQuery. Prefer a count/index-driven approach (e.g., maintain an activeSkillsCount in a singleton doc updated on create/soft-delete) rather than fetching all docs just to count them.

Prompt To Fix With AI

This is a comment left during a code review.
Path: convex/skills.ts
Line: 744:751

Comment:
[P1] `countPublicSkills` does a full `.collect()` and then returns `skills.length`, which will scan and materialize *every* active skill doc. On larger datasets this will be slow and can hit Convex limits, especially since `/skills` mounts it unconditionally via `useQuery`. Prefer a count/index-driven approach (e.g., maintain an `activeSkillsCount` in a singleton doc updated on create/soft-delete) rather than fetching all docs just to count them.

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

[P3] The header currently renders Skills{' '}{totalSkills...} which shows a bare number with no delimiter/label. This can read as part of the title and may be confusing for screen readers. Consider formatting as e.g. Skills (123) or adding an aria-label/visually-hidden label for the count.

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/routes/skills/index.tsx
Line: 228:231

Comment:
[P3] The header currently renders `Skills{' '}{totalSkills...}` which shows a bare number with no delimiter/label. This can read as part of the title and may be confusing for screen readers. Consider formatting as e.g. `Skills (123)` or adding an `aria-label`/visually-hidden label for the count.

How can I resolve this? If you propose a fix, please make it concise.