Skip to content

Conversation

@julie-sullivan
Copy link
Collaborator

// for VCV records
additionalProperties: [
    ...,
   {
     "name": "scvIds",
     "value": "SCV00403947,SCV00403949,SCV0040393423434"
   }
]

// for SCV records
additionalProperties: [
   ...,
   {
     "name": "vcvIds",
     "value": "39478"
   }
]

I see you have added VCV_ID as well. Should I leave them both? Can I remove one? CellBase users have already updated their code to expect "vcvIds" so if we could keep that one it would be easier!

# which one to remove, have two now
    {
      "id": null,
      "name": "vcvIds",
      "value": "7109"
    },
    {
      "id": "VCV_ID",
      "name": "VCV ID",
      "value": "7109"
    },
  1. See v4.10.0 - Add additional properties to annotations #586 where I put this change into v4.
  2. @javild code reviewed the original request.
  3. This is only the ClinVar IDs change from the original PR, MNV update will come later.
  4. The unit test included in this PR passes. (the COSMIC tests failed for me, before this change).
  5. there are two VCV entries in additional properties, let me know which one to remove. If any!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant