feat(luks2): implement atomic initialization check with subsystem #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --subsystem cryptpilot option to cryptsetup luksFormat in cryptpilot-convert.sh - Implement direct binary LUKS2 header parsing to read subsystem field - Add mark_volume_as_initialized function to set subsystem after successful initialization - Modify is_initialized function to check for 'cryptpilot' subsystem - Call mark_volume_as_initialized after mkfs in init, open, and before_sysroot stages - Ensure atomicity: only fully initialized volumes (with subsystem set) are recognized as initialized This provides atomic initialization semantics: a volume is considered initialized only after both LUKS2 creation and mkfs are completed. Signed-off-by: Kun Lai <laikun@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements atomic initialization check using the cryptsetup subsystem feature. The changes ensure that a volume is considered initialized only after both LUKS2 creation and mkfs are completed successfully.
Changes
Motivation
This provides atomic initialization semantics: a volume is considered initialized only after both LUKS2 creation and mkfs are completed, preventing partially initialized volumes from being recognized as fully initialized.