feat: Add ghost/transparent variant to Textarea component (fixes #6)#7
Open
mithilP007 wants to merge 2 commits intoopenai:mainfrom
Open
feat: Add ghost/transparent variant to Textarea component (fixes #6)#7mithilP007 wants to merge 2 commits intoopenai:mainfrom
mithilP007 wants to merge 2 commits intoopenai:mainfrom
Conversation
Updated TypeScript definition to include 'ghost' variant alongside 'outline' and 'soft' variants. Addresses issue openai#6 - Part 1 of 2 (CSS styling to be added in next commit)
Implemented transparent ghost variant styling: - Transparent background with no border by default - Subtle box-shadow on focus for visual feedback - Invalid state indication with red border - Seamlessly blends with custom-styled containers Addresses issue openai#6 - Part 2 of 2 (completes the feature)
Collaborator
tylersmith-openai
left a comment
tylersmith-openai
left a comment
There was a problem hiding this comment.
Thank you for contributing, @mithilP007!
Before we merge this, let's add coverage in a few more spots:
- Add the new
ghostvariant to the Textarea variants storybook example. - Add
ghostto Input as well, for parity. - Similarly extend
Input's variants storybook example.
I'm also curious if a hover treatment should be involved here, like subtly peaking the border. For ghost, that would match the behavior I'd expect.
We could additionally support a bare or none variant that never applies border/background treatments under any conditions (leaving those decisions up to the integrator).
Comment on lines
+160
to
+161
| Ghost variant | ||
| ============================================= */ |
Collaborator
There was a problem hiding this comment.
nit
Suggested change
| Ghost variant | |
| ============================================= */ | |
| Ghost variant | |
| ============================================= */ |
| Ghost variant | ||
| ============================================= */ | ||
| &:where([data-variant="ghost"]) { | ||
| /* No background or border by default, blends with container */ |
Collaborator
There was a problem hiding this comment.
Let's avoid unnecessary comments
Suggested change
| /* No background or border by default, blends with container */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new
ghost(transparent) variant to theTextareacomponent, allowing the textarea to blend seamlessly with custom-styled containers without visible borders or background.Changes
TypeScript (
Textarea.tsx)"ghost"to theVariantsunion type for thevariantpropVariants<"outline" | "soft" | "ghost">CSS (
Textarea.module.css)Use Case
As described in issue #6, this variant enables developers to implement textareas in interfaces where the input field needs to blend with custom-styled containers, eliminating the need for
!importantCSS overrides.Testing
The implementation follows the existing pattern used in the Button component's ghost variant and is consistent with the design system's architecture.
Fixes #6