Skip to content

Conversation

@scheidtdav
Copy link
Collaborator

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

  1. Add checks to UI components that prevent rendering invalid geolocations and thus breaking the ui
  2. Check geolocation entries received via the api to ensure they are within value range
  3. Add a migration to add a table constraint preventing invalid data to be inserted

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

This is waiting for evaluation of the current production setup. We have to make sure not to break too much existing sensors with this change. Assuming there are close to none existing datasets with invalid lat/lng, we should be fine.
If not, we should somehow add meaningful graceful degradation to this (e.g. filtering out invalid locations).

@scheidtdav scheidtdav marked this pull request as ready for review December 17, 2025 11:26
@scheidtdav scheidtdav merged commit a6ac484 into dev Dec 17, 2025
6 checks passed
@scheidtdav scheidtdav deleted the fix/invalid-lat-lng-data branch December 17, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zooming out too far results in a crash of the map

3 participants