This repository was archived by the owner on Dec 16, 2024. It is now read-only.
[24] - Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts#35
Open
Abhinavcode13 wants to merge 1 commit intoopenMF:masterfrom
Open
[24] - Add monitorResources, measureTime, and Cleanup Enhancements to Mojafos Scripts#35Abhinavcode13 wants to merge 1 commit intoopenMF:masterfrom
Abhinavcode13 wants to merge 1 commit intoopenMF:masterfrom
Conversation
Abhinavcode13
changed the title
Abhinavcode13
changed the title
Abhinavcode13
changed the title
Collaborator
Author
|
changed the PR's name to be more issue-specific |
Collaborator
Author
|
PTAL, @elijah0kello. |
Abhinavcode13
changed the title
Abhinavcode13
changed the title
Collaborator
|
@Abhinavcode13 I have tried to run the code being sent it by this PR but for some reason, it looks broken. When I execute a script, it just brings this. It does not bring the MOJAFOS welcome word at all. It starts to just print mojaloop deployment logs. Kindly rebase from dev and make the PR to the dev branch. Here is evidence of the execution 
|
Collaborator
|
hi @Abhinavcode13 , @elijah0kello , I think we definitely want this instrumentation and looking at how it is done I think makes sense BUT please @Abhinavcode13 , can you please raise this pr against dev not master branch |
…ng in mojafos bash scripts
Abhinavcode13
force-pushed
the
add-instrumentation
branch
from
07ca1e6 to
23390a1
Compare
Abhinavcode13
changed the title
Collaborator
|
Kindly rebase from dev and see if the issue gets fixed then create the PR to dev. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #21 & #24