-
Notifications
You must be signed in to change notification settings - Fork 2
Jira/tbbas 2595 create shared workflow #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira/tbbas 2595 create shared workflow #5
Conversation
…le, running tests, and uploading reports - Add download framework action - Add install framework action - Add determine openDAQ version action - Add build and test simple device module with binary framework package
- Project README: overview, build/test instructions, openDAQ integration notes - framework-latest-release: inputs, outputs, usage - framework-download: inputs, usage - framework-install: inputs, usage, OS-specific install details
aeb8a16 to
03269c4
Compare
2f2df8e to
9bbe032
Compare
53b4c2f to
2e1f3fa
Compare
c3d7764 to
f69c877
Compare
d116544 to
3f25dda
Compare
| name: Download openDAQ framework release package from GitHub | ||
| description: "Download openDAQ package from GitHub" | ||
|
|
||
| inputs: | ||
| opendaq-release-version: | ||
| required: false | ||
| default: '' | ||
|
|
||
| destination-dir: | ||
| required: false | ||
| default: ${{ runner.temp }} | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Download openDAQ release | ||
| shell: bash | ||
| run: | | ||
| echo "::group::Download openDAQ package " | ||
| gh release download ${{ inputs.opendaq-release-version }} --repo openDAQ/openDAQ --pattern ${{ inputs.opendaq-package-filename }} --dir ${{ inputs.destination-directory }} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this entire .autosave file can be safely deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.github/workflows/ci.yml
Outdated
| pull_request: | ||
| branches: | ||
| - main | ||
| - jira/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run it on all pull requests on all branches?
pull_request:
branches:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
The push executes only for main branch, and the pull_request -- for any branches
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Compose framework filename | ||
| id: compose-framework-filename | ||
| uses: openDAQ/actions/framework-compose-filename@jira/TBBAS-2680-opendaq-gh-actions-github-api-wrapper-unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obviously, all of these should target the main branch, not this specific one before the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put the comment in the pull request description pointing to actual PRs that need to be merged before the current one.
83f2d18 to
a8a3025
Compare
… build and test - Add ci-framework.yml: reusable workflow for testing with openDAQ framework artifacts - Add module-build-test composite action: automated CMake configure, build, and test - Update ci.yml: use new composite action, add fail-fast: false for matrix jobs
a8a3025 to
7fdb861
Compare
No description provided.