You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 25, 2024. It is now read-only.
Subscriptions is a map and not an array, because of that checking on subscription._audioTrackId|_videoTrackId will actually not work.
For some reason, _audioTrackId and _videoTrackId is actually undefined. I am not sure if this is a good fix. The issue was caused with this commit: 7d31677
Thanks for your PR. Perhaps we need to correctly set _audioTrackId and _videoTrackId instead of using transportId since transportId is for transport. Multiple publications, subscriptions can share the same the same transport channel. Sometimes, transportId is the same as stream ID, but it's not guaranteed by design.
It could be set after a Subscription is created. And the initial audio track ID and initial video track ID are mediaOptions.audio.from and mediaOptions.video.from in subscribe method. You may store it in a map and read it when a subscription is created. Track IDs might be updated when user updates its source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscriptions is a map and not an array, because of that checking on
subscription._audioTrackId|_videoTrackIdwill actually not work.For some reason, _audioTrackId and _videoTrackId is actually
undefined. I am not sure if this is a good fix. The issue was caused with this commit: 7d31677For more information, see discussion in open-webrtc-toolkit/owt-server#1037
Closes #513