Remove implicit conversion from String -> const(char)[]#81
Merged
samsinsane merged 1 commit intomasterfrom Feb 20, 2026
Merged
Conversation
1 task
samsinsane
approved these changes
Feb 18, 2026
TurkeyMan
force-pushed
the
string_conversion
branch
2 times, most recently
from
0126e49 to
a0b8cbc
Compare
Member
Author
|
Good catches; thanks! They also revealed some other cruft that I missed in my post-rebase audit. |
TurkeyMan
force-pushed
the
string_conversion
branch
from
a0b8cbc to
af20170
Compare
- also don't attempt to compare user types if the types doesn't match!
TurkeyMan
force-pushed
the
string_conversion
branch
from
af20170 to
a804e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This had a lot of cascading effects, but I also found some bugs caused by the implicit conversion, so I'm sure it's the right way to go.