fix: Finally hooks do not get called when the provider is not ready #424#425
Merged
beeme1mr merged 4 commits intoopen-feature:mainfrom Jan 29, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 97.54% 97.55%
=======================================
Files 31 31
Lines 1387 1391 +4
=======================================
+ Hits 1353 1357 +4
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…eature#424 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow
changed the title
beeme1mr
approved these changes
Jan 29, 2025
Member
|
Hey @chrfwow, could you please add a test? |
…pen-feature#424 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
…pen-feature#424 Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
chrfwow
deleted the
Finally-hooks-do-not-get-called-when-the-provider-is-not-ready-#424
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Calls the finally hooks after flag evaluation was attempted, even whe nthe provider is not in a ready state.
Related Issue
Fixes #424