feat: Add evaluation details to finally hook stage #403#423
Merged
beeme1mr merged 12 commits intoopen-feature:mainfrom Jan 30, 2025
Merged
Conversation
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
…pen-feature#403 # Conflicts: # tests/features/steps/steps.py
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
==========================================
+ Coverage 97.54% 97.55% +0.01%
==========================================
Files 31 31
Lines 1387 1393 +6
==========================================
+ Hits 1353 1359 +6
Misses 34 34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Contributor
Author
|
The code coverage report fails because one line is not covered by tests. However, this line should not be reachable and therefore cannot be tested easily. I only added it to make the linter happy. |
beeme1mr
requested review from
federicobond,
gruebel,
lukas-reining,
thomaspoignant and
toddbaert
gruebel
reviewed
Jan 28, 2025
Signed-off-by: christian.lutnik <christian.lutnik@dynatrace.com>
Member
|
if there are no other objections, then I will merge end of week. |
beeme1mr
approved these changes
Jan 29, 2025
toddbaert
approved these changes
Jan 30, 2025
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
My Python is not great, but this looks spec compliant to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds the evaluation details to the finally hook
Related Issues
Fixes #403
How to test
Please make sure the e2e tests work, especially the part with
git submodule add --force https://github.com/open-feature/spec.git specinpyproject.toml.