stream: Implement BinaryStreamFormat#237
Open
german77 wants to merge 2 commits intoopen-ead:masterfrom
Open
Conversation
german77
force-pushed
the
streamFormat
branch
2 times, most recently
from
7ba5a8c to
0009ae7
Compare
Fuzzy2319
reviewed
Jan 15, 2026
Contributor
Fuzzy2319
left a comment
Fuzzy2319
left a comment
There was a problem hiding this comment.
I managed to get BinaryStreamFormat::readF32 matching sead::BinaryStreamFormat::readF32(sead::StreamSrc*, sead::Endian::Types) | decomp.me I will investigate further to avoid making everithing public.
@Fuzzy2319 made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
Contributor
|
@Fuzzy2319 Did you find a better match? |
Fuzzy2319
reviewed
Jan 24, 2026
Contributor
Fuzzy2319
left a comment
Fuzzy2319
left a comment
There was a problem hiding this comment.
sead::BinaryStreamFormat::readF32(sead::StreamSrc*, sead::Endian::Types) | decomp.me
@Fuzzy2319 made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved.
german77
force-pushed
the
streamFormat
branch
from
0009ae7 to
3205288
Compare
german77
force-pushed
the
streamFormat
branch
from
3205288 to
06a32c1
Compare
Contributor
Author
|
Rebased to include fuzzy changes. I had to work the solution a bit since it broke writeF32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream formats aren't that useful if the actual memory operations aren't implemented. This fixes fromHostXXX functions that referenced the wrong table.
BinaryStreamFormat::readF32isn't matching. Floats are loaded different due casting from raw to float but I couldn't spot the error. https://decomp.me/scratch/L5MO9BinaryStreamFormat::readStringisn't matching. This one just feels wrong, the implementation I come up leaves me a lot of questions. The write operation just takes the smaller size and fills the rest with null terminators. https://decomp.me/scratch/jCek1This change is