Conversation
MonsterDruide1
left a comment
There was a problem hiding this comment.
Where did you get the DPD stuff from?
@MonsterDruide1 reviewed 15 files and all commit messages, and made 5 comments.
Reviewable status: 15 of 19 files reviewed, 4 unresolved discussions (waiting on @Fuzzy2319).
include/nn/irs/ImageTransferProcessorConfig.h line 7 at r1 (raw file):
namespace nn::irsensor { struct __attribute__((packed)) ImageTransferProcessorConfig {
Why use packed here?
Suggestion:
struct ImageTransferProcessorConfig {include/nn/irs.h line 44 at r1 (raw file):
const IrCameraHandle& handle); void* CalculateMomentRegionStatistic(const MomentProcessorState* state, const Rect&, s32, s32, s32, s32); // TODO: change return type
Suggestion:
IrsMomentStatistic CalculateMomentRegionStatistic(const MomentProcessorState* state, const Rect&, s32, s32, s32,
s32);include/nn/irs/TeraPluginProcessorState.h line 10 at r1 (raw file):
s64 timeStamp; s32 ambientNoiseLevel; u8 data[0x12c]; // TODO: this is unknown
https://switchbrew.github.io/libnx/irs_8h_source.html
Suggestion:
u8 pluginData[0x12c];include/nn/irs/TeraPluginProcessorConfig.h line 10 at r1 (raw file):
s8 _1; s8 _2; s8 _3;
Suggestion:
s8 _1; // [6.0.0+]
s8 _2; // [6.0.0+]
s8 _3; // [6.0.0+]
Fuzzy2319
left a comment
There was a problem hiding this comment.
I used switchbrew website as a reference, it was said that on pre 4.0 sdk pointing stuff was named dpd so I made these struct based on that which seems to fit on ghidra.
@Fuzzy2319 made 5 comments.
Reviewable status: 15 of 19 files reviewed, 4 unresolved discussions (waiting on @MonsterDruide1).
include/nn/irs/ImageTransferProcessorConfig.h line 7 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Why use
packedhere?
if I remove the packed the compiler will add 4 bytes of padding after format which is wrong according to switchbrew.
include/nn/irs/TeraPluginProcessorState.h line 10 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Done.
include/nn/irs.h line 44 at r1 (raw file):
const IrCameraHandle& handle); void* CalculateMomentRegionStatistic(const MomentProcessorState* state, const Rect&, s32, s32, s32, s32); // TODO: change return type
Done.
include/nn/irs/TeraPluginProcessorConfig.h line 10 at r1 (raw file):
s8 _1; s8 _2; s8 _3;
Done.
MonsterDruide1
left a comment
There was a problem hiding this comment.
@MonsterDruide1 reviewed 7 files and all commit messages, and resolved 4 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Fuzzy2319).
This PR adds an header for the irs service.
This change is