Skip to content

fs: Add MountSaveData header#51

Merged
MonsterDruide1 merged 1 commit intoopen-ead:masterfrom
german77:saveData
Dec 24, 2025
Merged

fs: Add MountSaveData header#51
MonsterDruide1 merged 1 commit intoopen-ead:masterfrom
german77:saveData

Conversation

@german77
Copy link

@german77 german77 commented Nov 27, 2025

I need the Uid overload of MountSaveData


This change is Reviewable

Copy link

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @german77).


include/nn/fs/fs_save.h line 15 at r1 (raw file):

Result MountSaveData(const char*, UserId);
Result MountSaveData(const char*, const nn::account::Uid&);
Result MountSaveData(const char*, ApplicationId, const nn::account::Uid&);

This doesn't seem to exist. This variant is not used in the game, and when looking at the SDK, there is either nn::ncm::ApplicationId being used, or the function is called MountSaveDataReadOnly.

Copy link
Author

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1).


include/nn/fs/fs_save.h line 15 at r1 (raw file):

Previously, MonsterDruide1 wrote…

This doesn't seem to exist. This variant is not used in the game, and when looking at the SDK, there is either nn::ncm::ApplicationId being used, or the function is called MountSaveDataReadOnly.

Unless my eyes are deceiving me it does exist. I'm using referencing sdk 16.2.0. Although I don't particularly need it as is not used in SMO

Code snippet:

/* nn::fs::MountSaveData(char const*, nn::ApplicationId, nn::account::Uid const&) */

void nn::fs::MountSaveData(char *param_1,ApplicationId param_2,Uid *param_3)

{
  UserId UVar1;
  
  UVar1 = ConvertAccountUidToFsUserId(param_3);
  MountSaveData(param_1,param_2,UVar1);
  return;
}

Copy link

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonsterDruide1 made 1 comment and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @german77).


include/nn/fs/fs_save.h line 15 at r1 (raw file):

Previously, german77 (Narr the Reg) wrote…

Unless my eyes are deceiving me it does exist. I'm using referencing sdk 16.2.0. Although I don't particularly need it as is not used in SMO

Ah, I usually just look at SMO, not later games/SDKs. Can confirm that it exists on newer versions.

@MonsterDruide1 MonsterDruide1 merged commit 0787e16 into open-ead:master Dec 24, 2025
2 checks passed
@german77 german77 deleted the saveData branch December 24, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants