Remove nn::nex headers in favor of a new repository#44
Merged
leoetlino merged 4 commits intoopen-ead:masterfrom May 29, 2025
Merged
Remove nn::nex headers in favor of a new repository#44leoetlino merged 4 commits intoopen-ead:masterfrom
leoetlino merged 4 commits intoopen-ead:masterfrom
Conversation
leoetlino
approved these changes
May 16, 2025
leoetlino
left a comment
leoetlino
left a comment
There was a problem hiding this comment.
only had a cursory glance but lgtm
MonsterDruide1
approved these changes
May 24, 2025
MonsterDruide1
left a comment
MonsterDruide1
left a comment
There was a problem hiding this comment.
Reviewed 25 of 25 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @GRAnimated)
|
Shouldn’t this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all headers for nn::nex since it is an optional addon to the SDK for developers. I've moved the existing headers and started implementing classes in open-ead/NintendoSDK-NEX. This includes moving headers to their correct location based on asserts.
This change is