Skip to content

Conversation

@german77
Copy link

GLOB_RECURSE doesn't reload the files when is built as a subproject. This causes compiler issues like the ones seen here https://ci.botw.link/#/builders/5/builds/127

For this reason I decided to include all files explicitly. Header files might need the same treatment but we will find out once I rebuilt the sead PR.

@MonsterDruide1
Copy link

For add_library and add_executable, it can cause CMake to generate certain IDE-integrated buildsystems like Visual Studio to display those header files in a perhaps more-desirable way, but to my knowledge, that's it. It doesn't have impact on whether the buildsystem itself functions properly or not with respect to doing builds.

https://stackoverflow.com/a/76109228/9275661

We probably want the "better support for buildsystems", so please add the headers to add_library as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants