Skip to content

Conversation

@kenny-holloway
Copy link

The folder dis contains the entire DIS7 specification implemented in python. The code is generated by an updated version of the open-dis source generator.

I did not make the library of entity types for python yet.

@leif81
Copy link
Member

leif81 commented Nov 25, 2025

@kenny-holloway Thank-you for this.

Ken and I had been discussing this PR earlier in the year via email. This PR was produced by a tool Ken had created to autogenerate the code base.

Given it's a large change, we need to figure out best way that we could benefit from this, while minimizing impact on devs and users.

@leif81 leif81 self-requested a review November 27, 2025 00:03
Copy link
Member

@leif81 leif81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation I have is to modify the code generator to output code that matches the existing open-dis-python API here. The resulting PR would be a smaller diff containing the changes the tool is able to find and fix for free.

@kenny-holloway what do you think?

@ngjunsiang
Copy link
Contributor

I'll give my 2 cents here if that's okay.

The codebase isn't quite stable yet and is likely to undergo more changes, especially since not all the functionality is in yet, and some/much refactoring is going to be needed to add the remaining functionality.

It might perhaps be more useful to add the code generator itself, in a separate root directory or a separate repository if necessary. This would imply that future changes to the DIS7 codebase will need to take into account how the code generator works, and make appropriate changes to the code generator as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants