-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add ability to override middlewares for recurring nudges #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to override middlewares for recurring nudges #790
Conversation
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
809563e to
0786504
Compare
samuelallan72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kaustavb12 . I just had some queries about the command args.
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
|
Aside from the queries about the arguments, everything looks good to me! :) |
b0b3394 to
21323ab
Compare
samuelallan72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (just a couple of small nits, but otherwise all good!)
- I tested this: tested in the sandbox
- I read through the code
- I checked for accessibility issues
- Includes documentation
- @kaustavb12 unsure if this counts - do we need to do this? I guess we would want to upstream this patch too. [ ] Added to the Code Drift project board (for backports)
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/schedules/management/commands/__init__.py
Outdated
Show resolved
Hide resolved
ca90c97 to
a58135a
Compare
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites (cherry picked from commit 759e8f0)
* feat: add ability to override middlewares for recurring nudges * feat: add ability to run command for all sites (cherry picked from commit 759e8f0)
Description
This PR brings two changes to all the management command based on SendEmailBaseCommand:
Testing instructions
course_org_filtersetup for each site to map it to a unique org.Other information
Private Ref : BB-9883