removing rnd reuse logic (disabled by default)

[emmacware]

No description provided.

[slayoo]

OK, in the 2D kinematic setup, the reuse logic is enabled by default:

PySDM/examples/PySDM_examples/Morrison_and_Grabowski_2007/common.py

Line 32 in 20c8340

self.coalescence_optimized_random = True

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.71%. Comparing base (5168834) to head (c6e6507).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   86.77%   86.71%   -0.06%     
==========================================
  Files         414      412       -2     
  Lines       10500    10440      -60     
==========================================
- Hits         9111     9053      -58     
+ Misses       1389     1387       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[slayoo]

IIUC, with the reuse disabled, we are shuffling all n_sd numbers regardless of how many are actually needed in a given substep. So, I'd suggest that before removing the reuse logic, we implement a scheme to alter the amount of shuffled numbers depending on how many are actually needed in a given substep

[github-actions]

Stale pull request message